Use last element as QuickSort pivot#2185
Open
natecl wants to merge 3 commits into
Open
Conversation
daltino
reviewed
Jun 21, 2026
daltino
left a comment
daltino
left a comment
There was a problem hiding this comment.
The change to use the last element as the pivot in QuickSort seems reasonable, but it impacts the visiting count for the NOT_SORTED_ARRAY. The updated test ensures correctness, but the change to the visiting count requires verification to confirm it reflects the intended behavior. Also, double-check if these changes affect other test cases and the algorithm's performance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
array.pop()instead of usingarray.shift()from the front of the array.62to85.Closes #265.
Verification
npx jest src/algorithms/sorting/quick-sort/__test__/QuickSort.test.js --runInBandnpx eslint src/algorithms/sorting/quick-sort/QuickSort.js src/algorithms/sorting/quick-sort/__test__/QuickSort.test.jsNote
Related: #171 proposes a broader median-of-three QuickSort pivot change and also touches Kruskal. This PR is intentionally narrower and only addresses the
shift()pivot cost described in #265.